(BEDS-1184) return el rewards for guest dashboards #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuccaBitfly
requested changes
Feb 7, 2025
| @@ -678,7 +677,7 @@ func (d *DataAccessService) GetValidatorDashboardGroupRewards(ctx context.Contex | |||
| ret.ProposalClSlashingIncReward = ret.ProposalClSlashingIncReward.Add(entry.SlasherRewards.Mul(gWei)) | |||
| } | |||
|
|
|||
| ret.Proposal.Income = ret.Proposal.Income.Add(elRewards) | |||
| ret.Proposal.Income = ret.Proposal.Income.Add(d.convertElToMain(elRewards).Mul(decimal.NewFromInt(d.config.Frontend.ElCurrencyDivisor))) | |||
There was a problem hiding this comment.
Issue: You're converting the EL currency to the main currency and adding it to a field that contains values in the CL currency. On Gnosis, this would mean that you've converted xDai to GNO and then added it to a mGNO value. This field should be a ClElValue struct.
There was a problem hiding this comment.
Applied your suggestion. Could also just make use of the already existing ret.ProposalElReward, but keeping it explicit to reduce any future source of error also shouldn't hurt
Also if it's fine from the API side, would you please fix the frontend data type issue? 😅
Deploying beaconchain with
|
| Latest commit: |
6c8cc4b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce3652d2.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1184-fix-el-rewards.beaconchain.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.