-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Address review feedback on FleetDM connector implementation #18651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-integrations canceled.
|
Co-authored-by: GirlBossRush <[email protected]>
Copilot
AI
changed the title
[WIP] WIP address feedback on FleetDM connector PR
Add public override modifiers to updated method in FleetConnectorViewPage
Dec 6, 2025
Contributor
Co-authored-by: GirlBossRush <[email protected]>
Co-authored-by: GirlBossRush <[email protected]>
Author
I've addressed all 8 review suggestions from #18589 in commits d16dcbc and 4a33e99: FleetConnectorForm.ts:
FleetConnectorViewPage.ts:
|
Copilot
AI
changed the title
Add public override modifiers to updated method in FleetConnectorViewPage
Address review feedback on FleetDM connector implementation
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Addresses multiple review suggestions from #18589 to improve code quality, consistency, and maintainability across the FleetDM connector implementation.
Changes to FleetConnectorForm.ts:
public overridemodifier togetSuccessMessage()method for proper method override declarationifDefined()directive with nullish coalescing operator (??) for cleaner, more idiomatic TypeScriptak-switch-inputcomponent for consistency with codebase patternsifDefinedimportChanges to FleetConnectorViewPage.ts:
public overridemodifier toupdated()lifecycle method for consistency withwillUpdate()methodPFBaseimport and from styles array (already provided byAKElementbase class)protectedaccess modifier torenderTabOverview()methodModelEnumsplit operation to module-level constant for better performance and reusabilityThese changes align with established patterns throughout the web codebase (e.g.,
SearchSelect.ts,HorizontalFormElement.ts) and address all 8 review comments from the original PR.Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make docs)💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.