-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
web/admin: prevent file upload attempt when backend not managed #18646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jens Langhammer <[email protected]>
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18646 +/- ##
==========================================
- Coverage 93.22% 93.19% -0.04%
==========================================
Files 933 929 -4
Lines 51227 51175 -52
==========================================
- Hits 47757 47693 -64
- Misses 3470 3482 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dominic-r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-4c32f91a1d359f4a2201b574ade7f16d74662f19
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-4c32f91a1d359f4a2201b574ade7f16d74662f19Afterwards, run the upgrade commands from the latest release notes. |
web/src/admin/files/FileListPage.ts
Outdated
| <a | ||
| target="_blank" | ||
| class="pf-c-button pf-m-primary" | ||
| href=${docLink("/install-config/configuration/#storage-settings")} | ||
| >${msg("Learn more")}</a | ||
| > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <a | |
| target="_blank" | |
| class="pf-c-button pf-m-primary" | |
| href=${docLink("/install-config/configuration/#storage-settings")} | |
| >${msg("Learn more")}</a | |
| > | |
| ${msg("Read more about")} | |
| <a | |
| target="_blank" | |
| rel="noopener noreferrer" | |
| href=${docLink("/install-config/configuration/#storage-settings")} | |
| >${msg("Storage Settings")}</a | |
| >. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer keeping it as a single string in the link since that makes translation a lot easier (with regards to where the button is placed in the sentence)
Signed-off-by: Jens Langhammer <[email protected]>
uploading with an un-manageable backend results in a 405
This will only show up if you deploy in k8s and don't configure S3 and dont have a PVC