Skip to content

core/groups: optimize prefetch queries to fetch only required fields #18448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joaocfernandes wants to merge 2 commits into
base: main
Choose a base branch
from
Open

core/groups: optimize prefetch queries to fetch only required fields #18448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e284b91
perf(groups): Optimize prefetch queries to fetch only required fields
joaocfernandes Nov 29, 2025
789573c
rework a bit
rissson Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions authentik/core/api/groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@
from authentik.rbac.api.roles import RoleSerializer
from authentik.rbac.decorators import permission_required

PARTIAL_USER_SERIALIZER_MODEL_FIELDS = [
"pk",
"username",
"name",
"is_active",
"last_login",
"email",
"attributes",
]


class PartialUserSerializer(ModelSerializer):
"""Partial User Serializer, does not include child relations."""
Expand All @@ -42,16 +52,7 @@ class PartialUserSerializer(ModelSerializer):

class Meta:
model = User
fields = [
"pk",
"username",
"name",
"is_active",
"last_login",
"email",
"attributes",
"uid",
]
fields = PARTIAL_USER_SERIALIZER_MODEL_FIELDS + ["uid"]


class RelatedGroupSerializer(ModelSerializer):
Expand Down Expand Up @@ -262,7 +263,14 @@ def get_queryset(self):
base_qs = Group.objects.all().prefetch_related("roles")

if self.serializer_class(context={"request": self.request})._should_include_users:
base_qs = base_qs.prefetch_related("users")
# Only fetch fields needed by PartialUserSerializer to reduce DB load and instantiation
# time
base_qs = base_qs.prefetch_related(
Prefetch(
"users",
queryset=User.objects.all().only(*PARTIAL_USER_SERIALIZER_MODEL_FIELDS),
)
)
else:
base_qs = base_qs.prefetch_related(
Prefetch("users", queryset=User.objects.all().only("id"))
Expand Down
Loading