You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for hunting down that bug. That has been there for a very long time.
We will need to detail this change in the release notes just in case people see some changes in the data returned after upgrading. This is nuanced though so I don't suspect it has hit too many people.
Nah, this is because the PR does not have access to the credentials I believe. If you were to merge this now, it will have them @gdey.
Maybe we can split the docker build step and make the publish step including login only happen on push to master.
This has to do with external PRs not being able to access the repo secrets. I have been trying to figure out how we could make that job conditional based on if you have access to the secrets or not. Here's a related discussion. Seems like a few work arounds also reference this iss.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refers to #869
use direct comparison instead of strings.Contains to filter layernames
happy to discuss if we need to support both approaches.