Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlackWordsFnis documented as using a func to get the word list, but it calledfn()once when the middleware was constructed and then behaved exactly likeBlackWordswith a frozen list. Any runtime change to the list (e.g. reloaded config) was silently ignored.This change moves the body-inspection logic into a shared internal
blackWords(func() []string)helper:BlackWords(words...)wraps the static slice in a closure (behaviour unchanged).BlackWordsFn(fn)now callsfnon every request, so updates are picked up.Added
TestBlackwordsFnDynamic, which changes the list after the middleware is created and checks that the next requests use the new list. It fails on the current code and passes with this change.go test -race ./...andgo vetpass.