add support for MariaDB ED25519 plugin #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gusted <[email protected]>>
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
mysql/util.go:89
- The new function 'CalcEd25519Password' should be covered by tests to ensure its correctness.
func CalcEd25519Password(scramble []byte, password string) ([]byte, error) {
lance6716
approved these changes
Feb 25, 2025
|
@heavycrystal @lance6716 could we create some unit tests for this and maybe also have a MariaDB test in CI? |
dveeden
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MariaDB doesn't support
caching_sha2_passwordorsha256_passwordauthentication plugins, and instead has a completely differentclient_ed25519plugin, which uses a modified version of the ED25519 algorithm. MariaDB recommends using this overmysql_native_password.This PR implements support for
client_ed25519. The bulk of this PR is taken from go-sql-driver/mysql#1518 with the author's permission.Co-authored-by: @Gusted