Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Correct the check for Resultset #983

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

dveeden
Copy link
Collaborator

@dveeden dveeden commented Feb 7, 2025

This is likely a regression introduced by #969

Found by running this code: #915 (comment)

Queries like SELECT 1 were working correctly, but DO 1 and SET ... were not as the code tried to write a resultset instead of an OK.

@dveeden
Copy link
Collaborator Author

dveeden commented Feb 7, 2025

Without this PR:

mysql-8.0.11> SELECT 1;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.00 sec)

mysql-8.0.11> DO 1;
ERROR 2027 (HY000): Malformed packet

With this PR:

mysql-8.0.11> SELECT 1;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.00 sec)

mysql-8.0.11> DO 1;
Query OK, 0 rows affected (0.00 sec)

@lance6716 lance6716 merged commit 6c3f3a6 into go-mysql-org:master Feb 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants