Add RFC 5929 channel binding support for SSPI client #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently on vacation and don't have quick access to an Active Directory to test this. I will once I'm back or find the time to set up an AD quickly myself. I would appreciate it if others would review the changes and provide feedback 😄 |
|
Alex merged in alexbrainman/sspi#18 now, so I have updated the go.mod accordingly. For anyone wanting to play around with this, microsoft has a support page where they describe what registry entry and values that configurates the active directory server to use channel binding tokens. Before the changes in this PR and the one in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to: alexbrainman/sspi#18
This PR should also not be merged before above PR is merged since it is strictly dependant on those changes.
In newer microsoft active directory versions, channel binding token is on by default, causing clients to fail to authorize.
These changes gives an option to enable the security context to be updated with a channel binding token.
I have tested manually against active directory servers that have this feature on and off, and after these changes along with above PR, I was able to connect and authorize as usual.
It is hard to write tests for things like this that talks to the operating system, but any pointers to how I can improve my tests would be appreciated, otherwise I hope this us up to the standard of the lib in general.