Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big refactoring of the repository #6

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Felixoid
Copy link
Contributor

@Felixoid Felixoid commented Nov 5, 2024

  • migrate to docker compose plugin
  • use carbonapi+grafana instead of graphite-web+nginx
  • improve SQL for graphite-clickhouse tables

@Felixoid Felixoid force-pushed the improved-tables-schema branch from 9b33262 to ac8b27a Compare January 9, 2025 22:27
@Felixoid Felixoid force-pushed the improved-tables-schema branch from d1bbefe to 8c15abd Compare March 25, 2025 18:47
@Felixoid Felixoid requested a review from Copilot April 1, 2025 11:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a major repository refactoring by migrating to the docker compose plugin, switching from graphite-web+nginx to carbonapi+grafana, and improving SQL for graphite-clickhouse tables.

  • Migrates container definitions and configurations to support docker compose.
  • Introduces new configuration files for carbonapi and graph templates.
  • Updates README instructions and port mappings to reflect the new services.

Reviewed Changes

Copilot reviewed 7 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
graphTemplates.yaml Adds new graph templates with various color schemes.
grafana-graphite-datasource.yaml Introduces a new datasource configuration for grafana.
docker-compose.yaml Updates container images, adds new services, and adjusts volume/port mappings.
carbonapi.yml Provides updated carbonapi configuration and upstream settings.
README.md Updates usage instructions and port mappings for the new services.
Files not reviewed (6)
  • Makefile: Language not supported
  • carbon-clickhouse.conf: Language not supported
  • graphite-clickhouse.conf: Language not supported
  • graphiteweb.conf: Language not supported
  • graphiteweb_entrypoint.sh: Language not supported
  • init.sql: Language not supported
Comments suppressed due to low confidence (1)

graphTemplates.yaml:51

  • There are unintended leading spaces in the color values; consider removing the extra whitespace for consistency.
    colorList: ["#6666ff"," #66ff66"," #ff6666"]

prefix: "carbonapi"
# rules on how to construct metric name. For now only {prefix} and {fqdn} is supported.
# {prefix} will be replaced with the content of {prefix}
# {fqdn} will be repalced with fqdn
Copy link
Preview

Copilot AI Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spelling mistake in the comment ('repalced'); consider correcting it to 'replaced'.

Suggested change
# {fqdn} will be repalced with fqdn
# {fqdn} will be replaced with fqdn

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant