Skip to content

Conversation

@Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Oct 16, 2025

This PR adds a quick approve button on PR page to allow reviewers to approve all pending checks.
Only users with write permission to the Actions unit can approve.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 16, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Oct 16, 2025
@silverwind
Copy link
Member

Would style it the same as "Hide all checks", e.g. just a "text button". From a UX perspective, there should only be one primary button visible on a page.

@Zettat123 Zettat123 force-pushed the quick-approval-action-btn branch from 3605d0f to 9cc80fe Compare October 17, 2025 01:41
@Zettat123
Copy link
Contributor Author

Would style it the same as "Hide all checks", e.g. just a "text button". From a UX perspective, there should only be one primary button visible on a page.

Removed the primary class. Please see the new screenshot.

@lunny lunny added this to the 1.26.0 milestone Oct 17, 2025
@Zettat123 Zettat123 force-pushed the quick-approval-action-btn branch from af3e509 to 709fdb6 Compare October 17, 2025 19:20
@Zettat123 Zettat123 marked this pull request as ready for review October 17, 2025 22:11
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 18, 2025
@lunny
Copy link
Member

lunny commented Oct 19, 2025

Replace #33326

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 20, 2025
@wxiaoguang wxiaoguang merged commit 897e48d into go-gitea:main Oct 20, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the quick-approval-action-btn branch October 20, 2025 10:46
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 20, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 23, 2025
* giteaofficial/main:
  Fix external render (go-gitea#35727)
  Refactor Actions Token Access (go-gitea#35688)
  Honor delete branch on merge repo setting when using merge API (go-gitea#35488)
  Don't block site admin's operation if SECRET_KEY is lost (go-gitea#35721)
  [skip ci] Updated translations via Crowdin
  fix attachment file size limit in server backend (go-gitea#35519)
  Make restricted users can access public repositories (go-gitea#35693)
  Fix various trivial problems (go-gitea#35714)
  Refactor legacy code (go-gitea#35708)
  Add quick approve button on PR page (go-gitea#35678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants