Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix team permission #34128

Merged
merged 6 commits into from
Apr 8, 2025
Merged

Fix team permission #34128

merged 6 commits into from
Apr 8, 2025

Conversation

wxiaoguang
Copy link
Contributor

The team.access_mode should be either none or admin/owner. For non-admin team, the real permissions are provided by team_unit.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 6, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 6, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Apr 6, 2025
@wxiaoguang wxiaoguang mentioned this pull request Apr 6, 2025
Closed
@wxiaoguang wxiaoguang force-pushed the fix-team-perm branch 2 times, most recently from 096d5a9 to 535f222 Compare April 6, 2025 11:05
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Apr 6, 2025
@yp05327

This comment was marked as resolved.

Sign in to view
@wxiaoguang
Copy link
Contributor Author

Comment #34128 (comment) and review #34128 (review) are all the same problem, fixed in c411cdb

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 7, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 8, 2025 03:51
@wxiaoguang wxiaoguang merged commit 07c6087 into go-gitea:main Apr 8, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the fix-team-perm branch April 8, 2025 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @yp05327 @lunny @GiteaBot