Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always show assignees on right #33006

Merged
merged 4 commits into from
Dec 29, 2024
Merged

always show assignees on right #33006

merged 4 commits into from
Dec 29, 2024
+24 −24

Conversation

metiftikci
Copy link
Contributor

Before

old_issue_list

After

new_issue_list

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 27, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 27, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 27, 2024
wxiaoguang
wxiaoguang previously approved these changes Dec 27, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 27, 2024
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 27, 2024
@wxiaoguang
Copy link
Contributor

Oh wait, it make mobile view worse .......

@metiftikci
Copy link
Contributor Author

what is the width you are checking?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 27, 2024 •
edited
Loading

"width": main stream phone screen width, provided by Chrome devtools.

Old:

image

New:

image

@metiftikci
Copy link
Contributor Author

actually that does not looks bad to me 😆 what do you suggest?

@wxiaoguang
Copy link
Contributor

actually that does not looks bad to me 😆 what do you suggest?

I think on narrow screen, it's better to wrap the title and the right part (assignee) in one line ..... I recalled an old issue : Improve flex-item overflow #31404 (31404 is still draft but the screenshot looks better)

@metiftikci
Copy link
Contributor Author

What about wrap only time?

large_issues

small_issues

@wxiaoguang
Copy link
Contributor

What about wrap only time?

LGTM

@metiftikci
Copy link
Contributor Author

done

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 28, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 28, 2024
@lunny lunny enabled auto-merge (squash) December 28, 2024 23:58
@lunny lunny merged commit 64bebc9 into go-gitea:main Dec 29, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 29, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 29, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@metiftikci @wxiaoguang @lunny @GiteaBot