Closed
Conversation
* Add support for cookbook uploads (V0 and V2). * Add support for chefignore files * Improve metadata.rb parsing to conform with Chef API * Add ServerApiVersion customization to http * Minor linting changes for newer golang versions Resolves go-chef#250
Member
|
Wow, that's a lot of work. I'll look this over just to see where you intend to go. Replacing ioutil is overdue so even though I'd probably make that a separate change it's ok to have here. |
Author
|
Went ahead and moved this over to #253 since I couldn't reopen this one after force pushing my branch, had discovered an issue in integration testing that occurred after adding the sandbox put retries and closed this while looking into it. Still have a few more changes to go for the integration tests but should have that out of draft soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my first pass at adding cookbook uploads to go-chef/chef.
Changes:
Resolves #250
Both unit and integration tests have been added for the new features. Please take a look and let me know what you think.