Rename no_prefix feature to unperfixed_malloc_on_supported_platforms#56
Conversation
|
“Override |
|
We might want to have this controlled by the same feature? |
|
I don’t know what the zone allocator is. Maybe @glandium can say more on this? |
|
The zone allocator is how jemalloc takes over malloc/free on OSX. Rather than replacing the symbols themselves, it pokes at some other state during initialization. |
|
Then I suppose it would make sense. The question is, would there be a reason to want to control them separately? |
f485f4f to
6d71767
Compare
6d71767 to
15eb477
Compare
|
They are separate in jemalloc’s config, so I’ve renamed to Also added a test and some docs. |
|
So this LGTM. @glandium, @Amanieu, thoughts? (you might want to check https://github.com/alexcrichton/jemallocator/pull/54 and https://github.com/alexcrichton/jemallocator/pull/53 for context). |
|
Thanks! If this needs tunning that can be done as new issues are discovered. |
Close gnzlbg#56 Signed-off-by: Jay Lee <[email protected]>
As proposed in discussion starting at https://github.com/alexcrichton/jemallocator/pull/54#issuecomment-399782432.
This describes what the feature does, including its possibly-unexpected platform-specific aspect.
Avoiding negation in the name also helps argue that this feature is “correct” insofar as Cargo feature flags adding functionality and not removing them, since Cargo selects the union of features requested by multiple dependents.