Skip to content

Update encoding for new NSFormatter subclasses #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gcasa wants to merge 51 commits into
base: master
Choose a base branch
from
+22,706 −16,754
Open

Update encoding for new NSFormatter subclasses #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
c6473bf
Update encoding for NSByteCountFormatter
gcasa Dec 6, 2025
bb2b4fe
NSDateIntervalFormatter initWithCoder/encodeWithCoder
gcasa Dec 6, 2025
79b2dbd
Fix keys for formatter
gcasa Dec 6, 2025
a94eea7
Implement NSISO8601DateFormatter NSCoding.
gcasa Dec 6, 2025
0694672
Add NSCoding implementation for NSLengthFormatter
gcasa Dec 6, 2025
370bebb
Add NSCoding implementation for NSMeasurementFormatter
gcasa Dec 6, 2025
b02aceb
Add NSCoding implementation for NSPersonNameComponentsFormatter
gcasa Dec 6, 2025
ad22c7b
Add NSCoder support for NSEnergyFormatter and NSISO8601DateFormatter …
gcasa Dec 7, 2025
c9f5541
Add changelog
gcasa Dec 7, 2025
cfff328
Fix compilation errors
gcasa Dec 7, 2025
7dfa969
Fix compilation errors
gcasa Dec 7, 2025
f873fc5
Add key archiver/archiver includes
gcasa Dec 7, 2025
6a9582b
Add key archiver/archiver includes
gcasa Dec 7, 2025
a91532e
Add key archiver/archiver includes
gcasa Dec 7, 2025
d9bd089
Merge branch 'master' into formatter_encoding
gcasa Dec 7, 2025
f1f7f36
Update NSPersonNameComponentsFormatter to implement NSCoding
gcasa Dec 7, 2025
2d4cec4
Merge branch 'formatter_encoding' of github.com:gnustep/libs-base int…
gcasa Dec 7, 2025
782d092
Include NSValue.h to get NSNumber to fix errors
gcasa Dec 7, 2025
0207cb1
Add basic tests for all new formatters.
gcasa Dec 8, 2025
d58e4dc
Add new tests for NSNumberFormatter encoding
gcasa Dec 8, 2025
1a905bd
Fix tests for NSMeasurementFormatter
gcasa Dec 8, 2025
2ad7bf1
Update formatters and tests.
gcasa Dec 8, 2025
08397cc
Fix SIGSEGV issue.
gcasa Dec 8, 2025
13833b8
Update NS*Formatter classes to manage NSNumberFormatter memory correc…
gcasa Dec 8, 2025
f13a43e
Fix formatting issues and errors during tests.
gcasa Dec 8, 2025
4ab07a0
Add format validation to the formatter tests.
gcasa Dec 8, 2025
730e698
Remove ObjC2.0 conventions.
gcasa Dec 9, 2025
ef5fd5a
Fixes to formatter tests.
gcasa Dec 9, 2025
8b27466
Remove reference to unimplemented method.
gcasa Dec 9, 2025
ddd30cd
Fix errors with formatter test
gcasa Dec 9, 2025
134b723
Fix warning, correct issue with handling reverse date interval
gcasa Dec 9, 2025
c5865fa
Add encoding tests.
gcasa Dec 9, 2025
cada9f3
Update macos encoding tests.
gcasa Dec 9, 2025
9d6b251
Add checks for specific macOS keys to verify compatibility
gcasa Dec 9, 2025
f89124a
Fix issues with proxy Keyed Archiver.
gcasa Dec 9, 2025
2e71d2c
Fix typo in setCalendar: method
gcasa Dec 9, 2025
ff6a97e
Implement stringForObjectValue:
gcasa Dec 11, 2025
43f71a3
Fix 8601 date formatter
gcasa Dec 11, 2025
420de2a
Properly implement NSDateIntervalFormatter stringFromDate:toDate:
gcasa Dec 12, 2025
c7280d1
Cleanup whitespace, indenting
gcasa Dec 12, 2025
c15a9be
Update NSEnergyFormatter to handle the long, short, and medium formats
gcasa Dec 12, 2025
6cf7be7
Update NSEnergyFormatter to eliminate whitespace, and re-indent
gcasa Dec 12, 2025
39bc565
Update NSEnergyFormatter to correct redundancy
gcasa Dec 12, 2025
ff71b0b
Move strings to common #defines
gcasa Dec 12, 2025
7266ead
Fix C89 issues with new changes
gcasa Dec 12, 2025
67e0166
Add test for NSLinguisticTagger
gcasa Dec 12, 2025
ccc57a3
Add NSLinguisticTagger test
gcasa Dec 12, 2025
774425f
Fix error with GCC
gcasa Dec 13, 2025
7750e16
Fix error with GCC
gcasa Dec 13, 2025
ffb7b38
Fix compilation issues
gcasa Dec 13, 2025
f396b36
Fix some memory leaks and standardise some formatting
rfm Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32,162 changes: 16,085 additions & 16,077 deletions ChangeLog
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Headers/Foundation/NSDateComponentsFormatter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ GS_EXPORT_CLASS
- (void) setZeroFormattingBehavior: (NSDateComponentsFormatterZeroFormattingBehavior)behavior;

- (NSCalendar *) calendar;
- (void) setCalender: (NSCalendar *)calendar;
- (void) setCalendar: (NSCalendar *)calendar;

- (NSDate *) referenceDate;
- (void) setReferenceDate: (NSDate *)referenceDate;
Expand Down
34 changes: 17 additions & 17 deletions Headers/Foundation/NSDateIntervalFormatter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#ifndef _NSDateIntervalFormatter_h_GNUSTEP_BASE_INCLUDE
#define _NSDateIntervalFormatter_h_GNUSTEP_BASE_INCLUDE

#include <Foundation/NSFormatter.h>
#import <Foundation/NSFormatter.h>

#if defined(__cplusplus)
extern "C" {
Expand All @@ -47,26 +47,26 @@ typedef NSUInteger NSDateIntervalFormatterStyle;
GS_EXPORT_CLASS
@interface NSDateIntervalFormatter : NSFormatter
{
NSLocale *_locale;
NSCalendar *_calendar;
NSTimeZone *_timeZone;
NSString *_dateTemplate;
NSDateIntervalFormatterStyle _dateStyle;
NSDateIntervalFormatterStyle _timeStyle;
NSLocale *_locale;
NSCalendar *_calendar;
NSTimeZone *_timeZone;
NSString *_dateTemplate;
NSDateIntervalFormatterStyle _dateStyle;
NSDateIntervalFormatterStyle _timeStyle;
}

// Properties
- (NSLocale *) locale;
- (void) setLocale: (NSLocale *)locale;
- (NSLocale*) locale;
- (void) setLocale: (NSLocale*)locale;

- (NSCalendar *) calendar;
- (void) setCalendar: (NSCalendar *)calendar;
- (NSCalendar*) calendar;
- (void) setCalendar: (NSCalendar*)calendar;

- (NSTimeZone *) timeZone;
- (void) setTimeZone: (NSTimeZone *)timeZone;
- (NSTimeZone*) timeZone;
- (void) setTimeZone: (NSTimeZone*)timeZone;

- (NSString *) dateTemplate;
- (void) setDateTemplate: (NSString *)dateTemplate;
- (NSString*) dateTemplate;
- (void) setDateTemplate: (NSString*)dateTemplate;

- (NSDateIntervalFormatterStyle) dateStyle;
- (void) setDateStyle: (NSDateIntervalFormatterStyle)dateStyle;
Expand All @@ -75,9 +75,9 @@ GS_EXPORT_CLASS
- (void) setTimeStyle: (NSDateIntervalFormatterStyle)timeStyle;

// Create strings
- (NSString *)stringFromDate:(NSDate *)fromDate toDate:(NSDate *)toDate;
- (NSString*) stringFromDate: (NSDate*)fromDate toDate: (NSDate*)toDate;

- (NSString *)stringFromDateInterval:(NSDateInterval *)dateInterval;
- (NSString*) stringFromDateInterval: (NSDateInterval*)dateInterval;

@end

Expand Down
4 changes: 2 additions & 2 deletions Headers/Foundation/NSLinguisticTagger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ enum
};
typedef NSUInteger NSLinguisticTaggerOptions;

DEFINE_BLOCK_TYPE(GSLinguisticTagRangeBoolBlock, void, NSLinguisticTag, NSRange, BOOL);
DEFINE_BLOCK_TYPE(GSLinguisticTagRangeRangeBoolBlock, void, NSLinguisticTag, NSRange, NSRange, BOOL);
DEFINE_BLOCK_TYPE(GSLinguisticTagRangeBoolBlock, void, NSLinguisticTag, NSRange, BOOL*);
DEFINE_BLOCK_TYPE(GSLinguisticTagRangeRangeBoolBlock, void, NSLinguisticTag, NSRange, NSRange, BOOL*);

GS_EXPORT_CLASS
@interface NSLinguisticTagger : NSObject
Expand Down
2 changes: 1 addition & 1 deletion Headers/Foundation/NSMassFormatter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ typedef NSInteger NSMassFormatterUnit;
@class NSNumberFormatter;

GS_EXPORT_CLASS
@interface NSMassFormatter : NSObject
@interface NSMassFormatter : NSFormatter
{
NSNumberFormatter *_numberFormatter;
BOOL _isForPersonMassUse;
Expand Down
Loading