sanitize uppercase filenames used in headers when adding new files to the project #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a new file in the project, esp. headers, some ifdef dance is added, to prevent double inclusion. This take the file name literally. For Categories, it's common to use NSSomeClass+Category as name, and that + sign breaks build. Therefore sanitize the generated uppercase header file name, replace any non alphanumeric and _ with _ before replacing the string in the template.
gcasa
approved these changes
Aug 30, 2024
Framework/PCFileCreator.m
Outdated
| if ([allowedCharacters characterIsMember:character]) | ||
| { | ||
| [sanitizedString appendFormat:@"%C", character]; | ||
| } else { |
Member
There was a problem hiding this comment.
This else should be on separate lines... like so...
}
else
{
Other than that looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #define something in C, only alphanumeric and _ are allowed.
When creating a new file in the project, esp. headers, some ifdef dance is added, to prevent double inclusion. This take the file name literally.
For Categories, it's common to use NSSomeClass+Category as name, and that + sign breaks build.
Therefore sanitize the generated uppercase header file name, replace any non alphanumeric and _ with _ before replacing the string in the template.