Skip to content

fix opening files with absolute Path from builders error log output #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
buzzdeee wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix opening files with absolute Path from builders error log output #35

buzzdeee wants to merge 1 commit into from

Conversation

@buzzdeee
Copy link
Contributor

@buzzdeee buzzdeee commented Aug 30, 2024

When there are files with absolute Paths in the PCProjectBuilder
error output, then the current buildPath is prepended, which is wrong.

Before prepending that, check if the file isAbsolutePath, and only prepend buildPath, when not.

@buzzdeee
When there are files with absolute Paths in the PCProjectBuilder
6a3a4cb 
error output, then the current buildPath is prepended, which is wrong.

Before prepending that, check if the file isAbsolutePath, and only
prepend buildPath, when not.
@buzzdeee buzzdeee requested a review from gcasa as a code owner August 30, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcasa gcasa Awaiting requested review from gcasa gcasa is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@buzzdeee