Changes to recipes, point to github.com/osmocom mirrors. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curtcorum
changed the title
…_env and python3_env
jdemel
reviewed
Jan 22, 2021
|
Hi @curtcorum, what is the reason for switching the osmocom mirrors? |
|
Johannes,
It was incredibly slow to download from my US location.
As long as the osmocom github mirrors are updated somewhat frequently it
is probably better for the worldwide community?
Curt
…On 1/22/21 4:01 PM, Johannes Becker wrote:
Hi @curtcorum <https://github.com/curtcorum>, what is the reason for
switching the osmocom mirrors?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#245 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANWQBVGD32244V3RA7JDX3S3HYTDANCNFSM4WGSNSEA>.
|
brianmwaters
reviewed
Feb 6, 2021
| @@ -36,3 +36,5 @@ config: | |||
| gitbranch: maint-3.8 | |||
| gr-lfast: | |||
| gitbranch: maint-3.8 | |||
| gr-iqbal: | |||
| gitbranch: gr3.8 | |||
There was a problem hiding this comment.
This fixes #246 for me; I was going to submit a PR but this will probably do.
jdemel
reviewed
Feb 6, 2021
| @@ -19,11 +19,11 @@ | |||
|
|
|||
| category: common | |||
| depends: | |||
| - cheetah | |||
There was a problem hiding this comment.
cheetah is only required for old releases. It was replaced by Mako because cheetah is abandoned and does not support Python3. Thus, this line will most likely trigger a complete Python2 install on a modern system. I'd argue that is an unwanted side-effect.
Mako, and previously Cheetah, are build time only dependencies. I'd argue that if you need an older release, please use whatever your package manager provides. In that case, you need neither Mako nor Cheetah installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.