use from_seed with 32 bytes instead of 8#64
Merged
Merged
Conversation
| /// Used to derive independent per-task RNGs for parallel sampling without | ||
| /// sharing the caller's RNG across threads. | ||
| pub(crate) fn fork_seed<R: RngCore + CryptoRng>(rng: &mut R) -> [u8; 32] { | ||
| let mut seed = [0u8; 32]; |
Member
There was a problem hiding this comment.
does u8 here imply some entropy loss?
Member
Author
There was a problem hiding this comment.
0u8 is just Rust buffer init, not the seed value..
the seed value comes from rng.fill_bytes(...)
auryn-macmillan
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid using
[ChaCha20::from_u64_seed()](https://docs.rs/rand_core/0.10.0/rand_core/trait.SeedableRng.html#method.seed_from_u64)for Shamir.