OKX solver update #109
OKX solver update #109
Conversation
src/infra/dex/okx/mod.rs
Outdated
| swap_request_future, | ||
| self.dex_approved_addresses | ||
| .try_get_with(order.sell, approve_transaction_request_future) | ||
| .map_err(|_: std::sync::Arc<Error>| Error::CacheEvaluationFailed(order.sell)) |
There was a problem hiding this comment.
I had to convert the error from Arc<Error> to Error in such a way, because Error cannot be cloned due to Http error. I think this is enough because in an error situation Http error can be checked by enabling trace level logs for instance.
There was a problem hiding this comment.
I see, do you need to specify std::sync::Arc<Error>? I think just |_| should do unless you want to make it apparent the error type.
There was a problem hiding this comment.
Yes, it is needed because compiler is not resolving automatically error type of the approve_transaction_request_future. Alternatively I could define return type inside the future like: Ok::<_, Error>(...) but I thought it looked worse. However now I'm thinking it may be better to define that type in the future, because the future itself provides a hint what is its return type (instead of providing type hint when this future is used by cache).
Summary
Addressing PR #104 comments.
Details
lru-cachecrate withmokato improve inserting data into the cache (now using segmentation blocking)./swapand/approve-transactionrequests in parallel to improve latency./approve-transactionrequest).How to test
Existing tests and newly added test.