Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searchbar improvements #978

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Searchbar improvements #978

merged 1 commit into from
Jan 12, 2025

Conversation

pol-rivero
Copy link
Contributor

  • Fixed a bug where search is always initialized as case-sensitive, even if the "March Case" checkbox is unchecked.
  • If search order is inverted, Shift+Enter will now search forward (instead of searching backward, which is the same direction as just pressing Enter).
  • While we're at it, add some margin to the "Search:" label to improve how it looks

@pol-rivero
Searchbar improvements
02710db 
- Fix bug where search is always initialized as case-sensitive, even if the "March Case" checkbox is unchecked.
- If search order is inverted, Shift+Enter will now search forward (instead of searching in the same direction as just Enter).
- While we're at it, add some margin to the "Search:" label to improve how it looks
@pol-rivero
Copy link
Contributor Author

@mattrose could you take a look at this PR and #979?

@mattrose
Copy link
Member

Will do

@pol-rivero
Copy link
Contributor Author

Thanks! :)

@mattrose
Copy link
Member

Love it. Thank you!

@mattrose mattrose merged commit 2969973 into gnome-terminator:master Jan 12, 2025
0 of 2 checks passed
@pol-rivero pol-rivero deleted the searchbar-improvements branch January 12, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pol-rivero @mattrose