[bug 971] - Save button throws KeyError when a multiple tab layout is… #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… saved using Save Button after closing the Preference window using close button. A fix is provided that last_active_term is not cleared on preference window closure using a parameter.
|
Q: Does the KeyError spit out affect the functionality at all, or is it just an error that is thrown because self.last_active_term[self.get_nth_page(tabnum)] is getting something that it's not expecting, but it doesn't actually affect the running of terminator as a whole. I'm just wondering if a better way of handling this error is to catch the KeyError when it's raised and just do the right thing, rather than alter the arguments to reconfigure. This seems like the simpler way to fix this to me. |
|
@mattrose I think you are right, I guess I was thinking in terms of error handling and not considering that in python world exception need not be an error. I will remove this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is described in #971 the KeyError should not be raised after following the steps.
The solution is to pass on flag so that the current terminals are not cleared on terminator.reconfigure when called from Preference window close button. Need to check if there is another efficient way to handle or parameter passing across to notebook.py is ok.