Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug 835] 835-crash-after-unzooming-a-single-terminal-inside-a-tab #835 #849

Merged
merged 2 commits into from
Feb 16, 2024
+0 −11
Merged

[bug 835] 835-crash-after-unzooming-a-single-terminal-inside-a-tab #835 #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff45920
[bug 835] 835-crash-after-unzooming-a-single-terminal-inside-a-tab #835
vssdeo Oct 20, 2023
c7c9fd0
[bug 835] 835-crash-after-unzooming-a-single-terminal-inside-a-tab #835
vssdeo Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions terminatorlib/notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,6 @@ def newtab(self, debugtab=False, widget=None, cwd=None, metadata=None, profile=N
self.set_current_page(tabpos)
self.show_all()
if maker.isinstance(term_widget, 'Terminal'):
#notify plugins of tab-change
dbg("emit tab-change for tabpos: %s " % tabpos)
term_widget.emit('tab-change', tabpos)
self.set_current_page(tabpos)
widget.grab_focus()

def wrapcloseterm(self, widget):
Expand Down
7 changes: 0 additions & 7 deletions terminatorlib/terminator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,6 @@ def find_terminal_by_uuid(self, uuid):
for terminal in self.terminals:
dbg('checking: %s (%s)' % (terminal.uuid.urn, terminal))
if terminal.uuid.urn == uuid:
if terminal.get_toplevel().is_child_notebook():
topchild = terminal.get_toplevel().get_child()
current_page = topchild.get_current_page()
#we need to emit signal for plugin and retain same page
dbg("current_page for tab-change-signal:%s" % current_page)
terminal.emit('tab-change', current_page)

return terminal
return None

Expand Down