-
Notifications
You must be signed in to change notification settings - Fork 415
FEDEV-3229: Audit scripts #2101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divhead
wants to merge
13
commits into
release
Choose a base branch
from
fedev-3229-audit-scripts
base: release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f9904da
chore(audit): add audit scripts to CI
divhead 8893ad0
chore: add messages to pre-commit hook
divhead a1d57c7
chore: ensure src/locales is added in pre-commit hook after linting
divhead 218fed5
chore: update CI workflows and dependencies, add new Yarn configuration
divhead a558a33
chore: update dependencies in package.json and yarn.lock, rename CI w…
divhead 36f010b
rebuild
divhead 286633c
chore: move bufferutil and utf-8-validate to optionalDependencies in …
divhead 88cafb4
chore: update bufferutil and utf-8-validate versions in package.json …
divhead 641f59a
merge conflicts
divhead 3c6e005
chore: remove optional deps
divhead 41f18fe
chore: update ci script
divhead 1bb1a9d
chore: update pre-commit hook to exit on first failed script
divhead 57223ef
Merge branch 'release' of github.com:gmx-io/gmx-interface into fedev-…
divhead File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| name: Audit | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - master | ||
| - release | ||
| - "release-*" | ||
| types: [opened, edited, synchronize, reopened] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| audit: | ||
| name: Audit | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "22" | ||
| cache: "yarn" | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Run security audit | ||
| run: yarn npm audit --severity moderate --no-deprecations | ||
|
|
||
| - name: Install SDK dependencies | ||
| run: | | ||
| cd sdk | ||
| yarn install --frozen-lockfile | ||
| - name: Run SDK security audit | ||
| run: | | ||
| cd sdk | ||
| yarn npm audit --severity moderate --no-deprecations | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| #!/bin/sh | ||
| set -e | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| yarn lingui:generate | ||
| yarn lint-staged | ||
| yarn tscheck | ||
| git add src/locales/ | ||
cursor[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| defaultSemverRangePrefix: "" | ||
| compressionLevel: mixed | ||
|
|
||
| enableGlobalCache: false | ||
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| plugins: | ||
| - path: .yarn/plugins/@yarnpkg/plugin-version.cjs | ||
| spec: "@yarnpkg/plugin-version" | ||
| enableImmutableInstalls: false | ||
|
|
||
| yarnPath: .yarn/releases/yarn-3.1.0.cjs | ||
| yarnPath: .yarn/releases/yarn-4.12.0.cjs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Invalid flag for yarn npm audit command
The
--no-deprecationsflag is not a valid option foryarn npm auditin Yarn Berry. The available flags are--all,--recursive,--severity,--json,--exclude, and--ignore. Using this invalid flag will cause the audit workflow to fail with an unknown option error, preventing security audits from running successfully.Additional Locations (1)
.github/workflows/audit.yml#L40-L41There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, it's wrong, audit works well with this flag