Full type coverage of public API #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmr
reviewed
Apr 12, 2022
| __since__ = '2011-09-23' | ||
| __version__ = version = '3.1.0' | ||
|
|
||
| __all__ = [ |
Author
There was a problem hiding this comment.
Oops, I thought __all__ doesn't work with modules, only with module variables. I put it back.
Author
|
@gmr do you have any other comments or anything else that I should fix? |
Owner
|
The scope of the changes are too big for me to include in 3.2. I'll look for including in 4.0, I need to examine the changes you made to the codegen in more depth and would like to include this as part of #38 given the scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.