Skip to content

Replay does not advance the server-event sequence counter (replayed events differ in sequence only) #50

Description

@gmliao

Symptom

When a recorded session is replayed via LandKeeper in reevaluation mode, server events emitted during replay have different sequence values than the recorded ones, even though the event content is identical. Cause: replayed inputs reuse the recorded sequence numbers, but outputCollector.takeNextSequence() is not advanced during replay, so the counter drifts.

Current state (workaround)

Examples/GameDemo/Sources/ReevaluationRunner/main.swift does a content-level recheck that ignores the sequence field and prints a warning ("known accounting gap") instead of failing with exit 6. Verified in PR #47: all 41 recordings match at content level.

Fix

Advance (or restore) the output sequence counter during replay so replayed server events are byte-identical to the recorded ones, then remove the content-level fallback in ReevaluationRunner.

Sources/ change → sst-core-change flow, own PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions