FOR REVIEW ONLY: Change queries enhancements for supporting deletes and key changes and API Publisher #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able publishing deletes using the Ed-Fi API Publisher (PosgreSQL only). Also includes: * Security metadata for the out-of-the-box Reader and Writer claim sets for use with the Ed-Fi API Publisher. * Authorization views for Local Education Agency-based API clients accessing tracked deletes on resources by incorporating both the appropriate "primary" association entities (i.e. StaffEdOrgEmploymentAssoc and StaffEdOrgAssignmentAssoc or StudentSchoolAssociations) and the tracked deleted versions.
…ion strategy for RelationshipsWithEdOrgsAndPeopleIncludingDeletes.
Implemented support for authorized key changes queries in the API. Deleting obsolete scripts for creating "tracked deletes" schema and tables. Refactored the QueryMetadataProviders for Key Changes and Deleted Items into a shared base class, using the Template Method pattern. Fixed issue with the hard-coded use of namespace as the column name once the alias support was removed from the tracked changes queries. Refactored to common abstractions, eliminating a good chunk of mostly redundant code. Tweak to naming of base class to match derived classes term order. Refactored queries for tracked changes to include grouping logic required for consolidating key changes for each item across the current change window. Added some XML documentation and made minor formatting changes.
…ingProperty and the DefiningConcreteProperty (the latter of which will return the final concrete entity occurrence the property).
…ion where base relationships would not be crawled when they should be because of the descriptor in the GeneralStudentProgramAssociation base class' key does not originate there.
…descriptions below). Updated SQL Server scripts for Change Queries with support for key changes. Added API security metadata scripts that add the readChanges action, and enable the appropriate authorization checks for API publishing. Add script to ensure obsolete triggers are dropped from existing SQL Server ODS tables. Added security metadata script for PostgreSQL to create permissions needed for the Sandbox claim set to be able to perform publishing actions. Reorganized Change Queries database script numbers to work cleanly with initdev process and the Populated Template database. Added SQL Server authorization view supporting use of deleted records for establishing authorized access to deletes and key changes.
…dual commit descriptions below). Added graceful handling of the exception condition when an action is not found in the security metadata (i.e readChanges in this case). Added some XML documentation and made minor formatting changes. Change DeletesController to serialize DateTime key values without the time portion.
…the DeletedItems and KeyChanges query factories.
…StrategyName rather than DisplayName for matching authorization strategies.
…esource reference on ResourceProperty to be a lazy property so that it is resolved after the ResourceModel reference is set.
… applied to a derived resource using the pattern that changes the name of the PK column (e.g. education organizations).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.