Fix a bug where the espnow peer list gets out of sync with the maintained PeerListClass. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @gmag11 @blazoncek Any word on this? Do you want something changed about it? |
|
I don't use peer list. I only use broadcasts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with stopping and starting quickespnow.
I suspect it's mentioned here: #19 (comment)
Personally, I'm experiencing an issue where when you stop espnow in order to enter light sleep and then resume espnow after waking back up, when you attempt to send a message to a peer that you've talked to before, an exception is thrown and the system reboots.
I think it'd be more beneficial to remove all peers with a call to quickespnow stop, however with message encryption perhaps that would throw a wrench into things.