DateTime.combine should default to time.tzinfo#20
Merged
glyph merged 1 commit intoglyph:trunkfrom Nov 12, 2025
Merged
Conversation
RazerM
commented
Nov 11, 2025
| date: Date, | ||
| time: Time[Optional[_tzinfo]], | ||
| tzinfo: Optional[_tzinfo] = None, | ||
| tzinfo: Optional[_tzinfo] = _missing, # type: ignore[assignment] |
Contributor
Author
There was a problem hiding this comment.
Some context for the sentinel I used here:
The Python implemention of CPython's datetime module uses True for the sentinel, but that is not part of the API and doesn't work with the builtin module:
❯ uv run --isolated --no-project -p 3.14 python
Python 3.14.0 (main, Oct 28 2025, 12:03:45) [Clang 20.1.4 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import _datetime
>>> import _pydatetime
>>> _pydatetime.datetime.combine(_pydatetime.date.today(), _pydatetime.time(tzinfo=_pydatetime.UTC), True)
datetime.datetime(2025, 11, 11, 0, 0, tzinfo=datetime.timezone.utc)
>>> _datetime.datetime.combine(_datetime.date.today(), _datetime.time(tzinfo=_datetime.UTC), True)
Traceback (most recent call last):
File "<python-input-3>", line 1, in <module>
_datetime.datetime.combine(_datetime.date.today(), _datetime.time(tzinfo=_datetime.UTC), True)
~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: tzinfo argument must be None or of a tzinfo subclass, not type 'bool'
Owner
|
I think there might be a slightly better way to express this, but the update is clearly correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19