perf: Handroll Deserialize implementations for CompletionResponse and CompletionTextEdit #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CompletionTextEdit In Zed, we've noticed that deserialization of CompletionResponse takes non-trivial amount of time (it takes ~380ms to deserialize a 60MB of JSON). We've attributed it to #[serde(untagged)] and rewrote the Deserialize impls manually, cutting down the time for the same scenario down to 120ms. The impls are actually pretty straightforward, as the types being deserialized have a distinct structure to them which allows us to dispatch to other Deserialize impl on the Visitor level.
osiewicz
added a commit
to zed-industries/zed
that referenced
this pull request
Jun 12, 2024
This also includes gluon-lang/lsp-types#287, which should significantly reduce the time it takes for us to deserialize completion lists.
osiewicz
added a commit
to zed-industries/zed
that referenced
this pull request
Jun 13, 2024
This also includes gluon-lang/lsp-types#287, which should significantly reduce the time it takes for us to deserialize completion lists. Release Notes: - N/A
ming900518
pushed a commit
to ming900518/zed
that referenced
this pull request
Jun 14, 2024
This also includes gluon-lang/lsp-types#287, which should significantly reduce the time it takes for us to deserialize completion lists. Release Notes: - N/A
fallenwood
pushed a commit
to fallenwood/zed
that referenced
this pull request
Jun 18, 2024
This also includes gluon-lang/lsp-types#287, which should significantly reduce the time it takes for us to deserialize completion lists. Release Notes: - N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Zed, we've noticed that deserialization of CompletionResponse takes non-trivial amount of time (it takes ~380ms to deserialize a 60MB of JSON). We've attributed it to #[serde(untagged)] and rewrote the Deserialize impls manually, cutting down the time for the same scenario down to 120ms. The impls are actually pretty straightforward, as the types being deserialized have a distinct structure to them which allows us to dispatch to other Deserialize impl on the Visitor level.