Add license field to @gluestack-ui/* scoped packages #2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahlozevski
force-pushed
the
main
branch
2 times, most recently
from
0ad5278 to
f232444
Compare
|
Hi @noahlozevski, thank you for this. could you please
Package version is handled by changeset and we update that when we release the packages i.e. after merging in the patch branch. |
The license attribute is missing when some of the packages are being published to npm. This change adds it to all of the package.json's with the MIT license (the one used at the root of the repo).
|
Hey! Thanks for the feedback. I just updated the PR with the license fields for all the package.json's being published in the repo, and I have rebased it on top of main. Let me know if you need anything else to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license field wasn't being published in the newer @gluestack-ui/* scoped packages on NPM. Example with @gluestack-ui/overlay, where the license field shows as "none".
I assume the license to be applied to these packages would be the same as the code in the rest of the repo, which is currently set to MIT license. I copied this attribute to all the packages manually, and bumped the version so it can be published and consumed by others upstream.
Adding the correct license is a requirement the CI tool I am working out of right now. I hope if the MIT license isn't the correct license for these packages, I can at least get the discussion going around the topic here.