[codex] restore bqplot 0.13 lab 3 visual coverage#187
Open
maartenbreddels wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 39.81% 39.81%
=======================================
Files 8 8
Lines 211 211
=======================================
Hits 84 84
Misses 127 127 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@maartenbreddels - thanks! should we wait until bqplot-gl is released so we can cleanup the reference to your bqplot-gl fork, or should we merge this and release quickly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up to the bqplot 0.12/0.13 compatibility work that was merged before the final CI cleanup landed.
The previous PR added bqplot 0.13 coverage but temporarily skipped the JupyterLab runner for that environment while we worked through the runtime/package split. That left the bqplot 0.13 visual job testing Solara and classic Notebook, but not the historical JupyterLab path.
Details
This restores JupyterLab coverage for the bqplot 0.13 visual environment while keeping it on JupyterLab 3. That matches the JupyterLab major version the project has historically tested, and avoids mixing the current compatibility PR with the separate JupyterLab 4 federated-extension problem.
The build-system dependency is also pinned to
jupyterlab>=3.6,<4. Without the upper bound, isolated builds can pull JupyterLab 4 to build the labextension metadata, even when the test environment itself is running JupyterLab 3. That mismatch produced confusing shared-package warnings in the browser and made it look like the runtime was testing one thing while the built bundle expected another.I also clarified the bqplot-gl loader error messages. The classic loader now distinguishes between “there is no RequireJS loader” and “bqplot-gl is missing from the classic frontend”, while the JupyterLab loader message no longer tells users to enable an nbextension.
Validation
npm run buildpassed using JupyterLab 3.5.2 on PATH.