Fix(ItemDevice): add missing declaration from define.php #19214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
stonebuzz
force-pushed
the
add_missing_define_declaration
branch
from
953c8b4 to
358f153
Compare
stonebuzz
changed the title
cedric-anne
approved these changes
Mar 17, 2025
trasher
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
by working on pluginsGLPI/genericobject#420
and missing related components
itemdevicedrive_typesitemdevicecontrol_typesI realised that the appropriate declarations were missing for registering a class (from
genericobjectin my case) on these componentsScreenshots (if appropriate):