-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cmd and with_job to FlowProject.operation #679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In the future, it can be helpful to do something like this instead:
def _func(...):
# do stuff
def func(...):
warnings.warn(FutureWarning, "func is deprecated")
_func(...)
and then call _func
internally, instead of using a warnings.catch_warnings
+ warnings.simplefilter
.
Also, check it with_job is used with a non-default aggregation rather than if an aggregator is specified as this is the best way to avoid errors.
@bdice I agree and it is generally what I do. Here, I think the solution is different in that I think we should remove the implementations in |
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 80.15% 80.24% +0.08%
==========================================
Files 32 32
Lines 3165 3189 +24
Branches 674 682 +8
==========================================
+ Hits 2537 2559 +22
- Misses 497 498 +1
- Partials 131 132 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Description
Does not break current behavior.
Motivation and Context
Closes #669
and replaces #671.
I had large suggestions to the way the code should be changed. I think this is much simpler to get the desired behavior.
Checklist: