[minor] Fix "get link" detail navbar feature#246
Conversation
Rather than change the reusable partial, I changed it at the point of usage * Detail page had already (in the nav part of the DOM) decided to only show this button when https_url was defined, so this coupling to variable name makes sense for the detail page Eventually feature needs a redesign
|
Could we keep the v2 templates the same, and remove |
|
Given that no one ever noticed and reported this in 4 yr, I suspect there's a lot of latitude. USGS (primary known v3 users) indicate that they're doing a full override. To clarify: |
|
Remove the change in v2, in case some portal out there does make use of these two items being different. In v3, remove |
Purpose
The default templates have a feature that doesn't render as written. The copy button is only shown when
https_urlis defined, but the field is filled in based on a (never-defined) variable calledcopy_to_clipboard_link.Short term fix
This is the narrowest possible fix, just to avoid that moment of puzzlement for any new user.
Use the same variable to render the copy widget that was used to render the button.
Reduces tiny risk of breakage by changing the URL variable at point of usage, to match what the page already assumed it was called in detail-nav.html
block detail_nav_get_link_button.Left the nominally reusable partial unchanged. (copy-to-clipboard.html).
Long term
Most people are probably sharing datasets (not single files). The current implementation is not super aligned with user needs, which may explain why no one noticed. This is the smallest possible fix to restore stock functionality.
Example
Before

After
