Update logging#67
Merged
Merged
Conversation
dtpthao
force-pushed
the
thao/update_log
branch
from
63940f0 to
e29512b
Compare
muse254
reviewed
Oct 23, 2025
Contributor
|
we can also update the |
Contributor
|
Lastly the json format on stdout for logs is not great for debugging ( we are losing on color-code highlights and logs are easier to read without nesting) |
Contributor
Author
utils already uses tracing and I've removed log usage in pingora-router, I think it's not neccessary to log there |
Contributor
Author
updated! |
dtpthao
force-pushed
the
thao/update_log
branch
from
1a8d8e1 to
2a94df7
Compare
muse254
approved these changes
Oct 27, 2025
* update influxdb2 docker * add statistics * Remove await from update_statistic call and run in background with tokio::spawn * remove certs folder copy in Dockerfiles and update influxdb2 tls feature in forward-proxy * replace enum with constants * check and update statistics for only valid requests * add request correlationId and latency to logs * remove log span because not working in cloud * remove unnecessary debug logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.