Skip to content

[Feature] Compression Layer #15#42

Open
muse254 wants to merge 2 commits into
developmentfrom
feat/compression-layer
Open

[Feature] Compression Layer #15#42
muse254 wants to merge 2 commits into
developmentfrom
feat/compression-layer

Conversation

@muse254
Copy link
Copy Markdown
Contributor

@muse254 muse254 commented Jul 10, 2025

@muse254
Copy link
Copy Markdown
Contributor Author

muse254 commented Jul 10, 2025

We need a common crate for similar primitives/utils

@muse254 muse254 marked this pull request as ready for review July 13, 2025 10:00
@muse254 muse254 requested review from dtpthao and stravid87 July 13, 2025 10:01
@dtpthao
Copy link
Copy Markdown
Contributor

dtpthao commented Nov 15, 2025

Oh sorry, I did not notice this PR, is it still need to be merged? @muse254

@muse254
Copy link
Copy Markdown
Contributor Author

muse254 commented Nov 15, 2025

We can bench it and see if it makes a difference, not sure. I remember its was noticeable for large blobs like images if I'm not wrong
I forgot about it too

@dtpthao
Copy link
Copy Markdown
Contributor

dtpthao commented Nov 15, 2025

We can bench it and see if it makes a difference, not sure. I remember its was noticeable for large blobs like images if I'm not wrong I forgot about it too

let's ask Ravi, @stravid87 do you want to bring this issue up globe-and-citizen/interceptor-refactor#15?

@stravid87
Copy link
Copy Markdown
Contributor

I would be ecstatic to revive this issue. We are at the point where these optimizations will start to matter.

However, I think we go step by step: implementing each fix, measuring performance, and then implementing other optimizations. This will, over time, I think point us to the most valuable interventions and the utility of the possible fixes we should focus on.

@dtpthao
Copy link
Copy Markdown
Contributor

dtpthao commented Nov 16, 2025

I would be ecstatic to revive this issue. We are at the point where these optimizations will start to matter.

However, I think we go step by step: implementing each fix, measuring performance, and then implementing other optimizations. This will, over time, I think point us to the most valuable interventions and the utility of the possible fixes we should focus on.

okay, I'll keep this issue in mind and circle back when appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants