handle PAX connection timeout #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pax TCP connected device may time out. when that happened, the client remained set but stream was not, which would result in the subsequent calls to the API failing with NullPointerException. Only solution was to create a new Device for each transaction.
This adds a catch around the potential connection timeout to reset the client, allowing the Device to be saved and reused for multiple transactions.
This also adds some minimal thread support, so that if Cancel is called while it is waiting to connect, it throws a meaningful error instead of a NullPointerException.
The PAX D190 is mobile and shuts off frequently, and doesn't accept connections, making these issues important for supporting the D190.