-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add support for unknown in typescript #2194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds support for `unknown` (and it's flow equivalent) in TypeScript. Closes glideapps#1619
Awesome! Please add an option for this in the typescript test fixture. |
@dvdsgl absolutely! Pulled down source to attempt this, but I'm not sure where in tests I'd add the specific options? Also ran into this issue while executing
|
Check the README for details. You want quicktestRenderSettings or some such name. |
Yup that was it. Actually found an unrelated bug, but icing this PR for a second. The source uses "any" as a catchall in a number of places where a more specific type ( |
@RichiCoder1 are there any plans to move forward with this PR? |
Adds support for
unknown
(and it's flow equivalent) in TypeScript.First PR and I made this constribution mostly via the GitHub UI, happy to do more if needed!
Closes #1619