Add dynamic/decode nullable_subfield decoder #811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Hillyerd <[email protected]>
|
Thank you but we do not accept unplanned PRs, any additions will need to be discussed beforehand. What's best here is still unclear to me, we will need to think through the options more. |
|
Re: discussions, I did that with my proposal linked above, but maybe it should have been a GH issue instead of a GH discussion. Please consider adding a CONTRIBUTING.md with some guidance, given the lack of issue and PR templates in this repo, it's not easy to know where to start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a spin-off of #809 and my related proposal.
This implements a
nullable_subfielduse-style decoder, which supports Nil values along the path; someting thatoptional_atdoes not.Let me know if this seems reasonable and I will spend some time on docs and change-log. I went a little overboard on tests, happy to eliminate any that seem unnecessary.