Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic/decode nullable_subfield decoder #811

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhillyerd
Copy link
Contributor

@jhillyerd jhillyerd commented Mar 8, 2025

This is a spin-off of #809 and my related proposal.

This implements a nullable_subfield use-style decoder, which supports Nil values along the path; someting that optional_at does not.

Let me know if this seems reasonable and I will spend some time on docs and change-log. I went a little overboard on tests, happy to eliminate any that seem unnecessary.

@lpil
Copy link
Member

lpil commented Mar 8, 2025

Thank you but we do not accept unplanned PRs, any additions will need to be discussed beforehand. What's best here is still unclear to me, we will need to think through the options more.

@jhillyerd
Copy link
Contributor Author

Re: discussions, I did that with my proposal linked above, but maybe it should have been a GH issue instead of a GH discussion.

Please consider adding a CONTRIBUTING.md with some guidance, given the lack of issue and PR templates in this repo, it's not easy to know where to start.

@jhillyerd jhillyerd marked this pull request as draft March 9, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants