Add split and split_once to bit_array module #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackurat
force-pushed
the
add-bitarray-split
branch
from
f4511c5 to
14b8688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR solves issue #568 and also adds a
splitfunction. Bothsplitandsplit_oncefunctions as their counterparts in the thegleam/stringmodule, and have feature parity across the targets.There are two older PRs (#571, #629) which addresses this, but they seem to be outdated/abandoned.
The
splitfunction could take options to make it have feature parity with Erlang'sbinary:split/3, but I opted for a simpler version here. Let me know if you'd like me to add the options feature.