Unaligned bit arrays on the JavaScript target #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
2 times, most recently
from
04fbf8e to
a938a2d
Compare
richard-viney
changed the title
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
4 times, most recently
from
7e599c5 to
d2bfa0c
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
3 times, most recently
from
ef7bedf to
12b7ec3
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
5 times, most recently
from
2449e2c to
568d07e
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
2 times, most recently
from
ffe3918 to
6bcb8c5
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
from
6bcb8c5 to
ddd0692
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
7 times, most recently
from
35317a7 to
ef7e4c7
Compare
|
@lpil Ready for review as the new tests now pass when run against nightly |
lpil
reviewed
Feb 19, 2025
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
from
ef7e4c7 to
67be2fb
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
from
67be2fb to
ec51b6b
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
2 times, most recently
from
4a43ea8 to
e672381
Compare
|
Great. Everything's been simplified to assume a minimum Gleam version of v1.9. The CI failures are resolved by gleam-lang/gleam#4266 (or alternatively by waiting for the v1.9 release and specifying that version in |
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
from
e672381 to
615591d
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
3 times, most recently
from
430a444 to
3b6b6bd
Compare
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
from
3b6b6bd to
bb0b015
Compare
|
Is this ready for review? :) |
|
Yes the only remaining thing is that it's specifying "1.9.0-rc1" in CI and this should be updated to "1.9.0" when it's available. |
richard-viney
force-pushed
the
js-unaligned-bit-arrays
branch
from
bb0b015 to
29471e6
Compare
|
Updated for the Gleam 1.9 release |
lpil
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to support unaligned bit arrays on the JavaScript target.
The minimum Gleam version is now 1.9.0.