Do not loose information about definition groups #4368
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed to implement mutual recursion TCO on the JS target. At the moment we throw away the different definitions groupings after analysis by flattening all the groups when storing those in the typed module. In this PR I change the internal module representation to make sure we store each group separately; this way code generation will be able to work with groups of related functions!
As a side note I've also done quite some renaming here: the codebase was calling a module's definitions
statements
despite those being definitions (and their type is indeedUn/TypedDefinition
). And theStatement
type andstatement
name is already widely used to refer to the statements that are part of a function's body, so now we use distinct names to refer to module definitions and statements