Include both shell and ps1 entrypoint scripts with gleam export erlan… #4364

Ummon · 2025-03-16T22:08:53Z

lpil

Thank you! Could you update the changelog also please 🙏

It would be great to also update the CI workflow to test that both files to ensure they exist

Lines 190 to 202 in 1840b69

    
                 - name: test/project_erlang export erlang-shipment (non-windows) 
        
                   run: | 
        
                     gleam export erlang-shipment 
        
                     ./build/erlang-shipment/entrypoint.sh run 
        
                   working-directory: ./test/project_erlang 
        
                   if: ${{ runner.os != 'Windows' && matrix.run-integration-tests }} 
        
                 - name: test/project_erlang export erlang-shipment (windows) 
        
                   run: | 
        
                     gleam export erlang-shipment 
        
                     .\build\erlang-shipment\entrypoint.ps1 run 
        
                   working-directory: ./test/project_erlang_windows 
        
                   if: ${{ runner.os == 'Windows' && matrix.run-integration-tests }}

lpil · 2025-03-17T11:19:01Z

compiler-cli/src/export.rs

-static ENTRYPOINT_TEMPLATE: &str = include_str!("../templates/erlang-shipment-entrypoint.sh");
+static ENTRYPOINT_TEMPLATE_POWERSHELL: &str =
+    include_str!("../templates/erlang-shipment-entrypoint.ps1");
+static ENTRYPOINT_TEMPLATE_BOURNE_SHELL: &str =


It's not bourne shell, it's POSIX shell!

lpil · 2025-03-17T11:19:40Z

compiler-cli/src/export.rs

+            ENTRYPOINT_FILENAME_BOURNE_SHELL,
+            ENTRYPOINT_TEMPLATE_BOURNE_SHELL,
+        ),
+    ] {


Use functions for code reuse please, not loops

lpil · 2025-03-17T11:20:14Z

compiler-cli/src/export.rs

-    {entrypoint}
+    println!(
+        "
+It can be copied to a compatible server with Erlang installed and run with one of the following scripts:


Wrap before 80 columns please.

lpil · 2025-03-17T11:20:20Z

compiler-cli/src/export.rs

+        "
+It can be copied to a compatible server with Erlang installed and run with one of the following scripts:
+    - {ENTRYPOINT_FILENAME_POWERSHELL} (PowerShell script)
+    - {ENTRYPOINT_FILENAME_BOURNE_SHELL} (Bourne Shell script)


It's not bourne shell

lpil · 2025-03-17T11:20:41Z

compiler-cli/src/export.rs


-    {entrypoint}
+    println!(


Do not introduce an extra print statement please 🙏

"Bourne Shell" -> "POSIX Shell".

Ummon · 2025-03-17T17:21:05Z

For the CI workflow, should I replace the two steps by one like that (I'm not familiar with github workflows)?:

      - name: test/project_erlang export erlang-shipment
        run: |
          gleam export erlang-shipment
          .\build\erlang-shipment\entrypoint.ps1 run
          .\build\erlang-shipment\entrypoint.sh run
        working-directory: ./test/project_erlang_windows
        if: ${{ matrix.run-integration-tests }}

lpil

Thank you!!

Include both shell and ps1 entrypoint scripts with gleam export erlan…

c2eae21

…g-shipment gleam-lang#4360

lpil reviewed Mar 17, 2025

View reviewed changes

Ummon force-pushed the main branch from 59a56f4 to c2eae21 Compare March 17, 2025 16:36

Ummon added 2 commits March 17, 2025 17:40

Use a function instead of a loop.

c45c680

"Bourne Shell" -> "POSIX Shell".

Wrap output string (80 columns).

882bfa8

Update changelog about 'gleam export erlang-shipment'

f6322ff

lpil approved these changes Mar 18, 2025

View reviewed changes

lpil enabled auto-merge (rebase) March 18, 2025 10:32

lpil merged commit a59aaca into gleam-lang:main Mar 18, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include both shell and ps1 entrypoint scripts with gleam export erlan… #4364

Include both shell and ps1 entrypoint scripts with gleam export erlan… #4364

Ummon commented Mar 16, 2025

lpil left a comment •

edited

Loading

lpil Mar 17, 2025

lpil Mar 17, 2025

lpil Mar 17, 2025

lpil Mar 17, 2025

lpil Mar 17, 2025

Ummon commented Mar 17, 2025 •

edited

Loading

lpil left a comment

	- name: test/project_erlang export erlang-shipment (non-windows)
	run: \|
	gleam export erlang-shipment
	./build/erlang-shipment/entrypoint.sh run
	working-directory: ./test/project_erlang
	if: ${{ runner.os != 'Windows' && matrix.run-integration-tests }}

	- name: test/project_erlang export erlang-shipment (windows)
	run: \|
	gleam export erlang-shipment
	.\build\erlang-shipment\entrypoint.ps1 run
	working-directory: ./test/project_erlang_windows
	if: ${{ runner.os == 'Windows' && matrix.run-integration-tests }}

Include both shell and ps1 entrypoint scripts with gleam export erlan… #4364

Include both shell and ps1 entrypoint scripts with gleam export erlan… #4364

Conversation

Ummon commented Mar 16, 2025

lpil left a comment • edited Loading

Choose a reason for hiding this comment

lpil Mar 17, 2025

Choose a reason for hiding this comment

lpil Mar 17, 2025

Choose a reason for hiding this comment

lpil Mar 17, 2025

Choose a reason for hiding this comment

lpil Mar 17, 2025

Choose a reason for hiding this comment

lpil Mar 17, 2025

Choose a reason for hiding this comment

Ummon commented Mar 17, 2025 • edited Loading

lpil left a comment

Choose a reason for hiding this comment

lpil left a comment •

edited

Loading

Ummon commented Mar 17, 2025 •

edited

Loading