Feat: Improve feedback on invalid name in new command and add CLI prompt to recover
#3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Hello! Thank you.
Let's make this print all the requirements for a name, as the ticket suggested.
For suggesting a new name, let's print something like Hint: try the_fixed_project_name if we can determine a suitable alternative. We can determine it by converting the project name to snake case and seeing if that passes.
This can be implemented in the error module and can be tested using snapshots, one for each kind of invalid name that we might encounter.
| }; | ||
| validate_name(&replacement_name)?; | ||
|
|
||
| if cfg!(test) { |
There was a problem hiding this comment.
Remove this please. We never use conditional test code.
|
Closing due to inactivity, please feel free to reopen. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1728