Skip to content

gh-794: create spherical harmonic transform wrapper functions #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
paddyroddy wants to merge 31 commits into
base: main
Choose a base branch
from
Open

gh-794: create spherical harmonic transform wrapper functions #805

paddyroddy wants to merge 31 commits into from
+203 −7

Conversation

@paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Nov 18, 2025 •
edited
Loading

Description

Ultimately, we need these transforms to be Array API compatible. Isolating them within the glass.harmonics module may make this easier for us further down the line.

Closes: #794

Changelog entry

Added: Spherical harmonic transforms in the harmonics module

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@paddyroddy paddyroddy self-assigned this Nov 18, 2025
@paddyroddy paddyroddy added enhancement New feature or request array-api Work is related to the Array API api An (incompatible) API change and removed array-api Work is related to the Array API labels Nov 18, 2025
@paddyroddy paddyroddy changed the base branch from main to paddy/issue-807 November 19, 2025 17:52
paddyroddy
paddyroddy commented Nov 19, 2025
View reviewed changes
glass/fields.py

# transform alm to maps
# can be performed in place on the temporary alm array
yield hp.alm2map(alm, nside, pixwin=False, pol=False, inplace=True)
Copy link
Member Author

@paddyroddy paddyroddy Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pixwin defaults to False

@paddyroddy paddyroddy marked this pull request as ready for review November 19, 2025 17:59
@paddyroddy paddyroddy marked this pull request as draft November 19, 2025 18:01
@paddyroddy paddyroddy mentioned this pull request Nov 20, 2025
Draft
5 tasks
@paddyroddy paddyroddy added the needs-2-reviewers Could be considered "controversial" so worth a second pair of eyes label Nov 20, 2025
@paddyroddy paddyroddy marked this pull request as ready for review November 21, 2025 17:42
connoraird
connoraird reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor

@connoraird connoraird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to benchmark these new functions?

@paddyroddy
Copy link
Member Author

paddyroddy commented Nov 27, 2025

Do we need to benchmark these new functions?

For now, they are just calling healpy so probably not?

@afinetooth afinetooth mentioned this pull request Nov 28, 2025
Closed
Base automatically changed from paddy/issue-807 to main December 1, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connoraird connoraird connoraird approved these changes

@ntessore ntessore Awaiting requested review from ntessore

Assignees

@paddyroddy paddyroddy

Labels

api An (incompatible) API change enhancement New feature or request needs-2-reviewers Could be considered "controversial" so worth a second pair of eyes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create wrapper functions for spherical harmonic transforms

3 participants

@paddyroddy @connoraird