Skip to content

Conversation

@paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Apr 30, 2025

Description

Make sure that the get_namespace method can be used even if one of the inputs is None.

I've also simplified the logic, so have changed not all(== to any(!=.

Closes: #612

Refs: #606

Checks

  • Is your code passing linting?
  • Is your code passing tests?
  • Have you added additional tests (if required)?
  • Have you modified/extended the documentation (if required)?
  • Have you added a one-liner changelog entry above (if required)?

@paddyroddy paddyroddy added bug Something isn't working array-api Work is related to the Array API labels Apr 30, 2025
@paddyroddy paddyroddy self-assigned this Apr 30, 2025
@paddyroddy paddyroddy marked this pull request as ready for review April 30, 2025 16:10
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @paddyroddy! This looks good to me!

@paddyroddy
Copy link
Member Author

Merging as needed for #597

@paddyroddy paddyroddy merged commit 5baec60 into main May 7, 2025
27 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-612 branch May 7, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

array-api Work is related to the Array API bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_namespace needs to handle None case

2 participants