-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #44
Improve CI #44
Conversation
d2c9c12
to
e22d8f8
Compare
Ah, unfortunately, I can't accept the changes to Also, why delete the |
e22d8f8
to
6c12ad0
Compare
I changed to use yettoapp/actions/setup-languages.
Repositories of commonly used Gems such as Puma, Faraday, and RuboCop do not contain .ruby-version file. |
For reference, below is the .gitignore for Ruby from github/gitignore. |
Oh, that's really interesting. In all my years of Ruby I never knew that was suggested. But, what if the code in the project is written using some new Ruby syntax, that the contributor doesn't have installed? In other words, how would I communicate to someone else that "Ruby 3.x.y is recommended to work with this project"? |
How about using TargetRubyVersion in .rubocop.yml? For reference, below is the .rubocop.yml of Faraday. |
Yeah...Faraday has over 5,000 stars and hundreds of millions of downloads. I consider this (and most of my projects) to be repositories that meet my needs, and my tooling. If the contribution and usage pool increases to the point where such formal versioning statements are needed, that's great. But for now, I like having all my projects formatted the same way (even if they're "wrong") so I have one less thing to think about. ✌️ In any event, it doesn't look like the lack of such versioning prevented earlier contributions, so I do not think this should be done. Thank you for your help and feedback though! |
@gjtorikian Sorry for reopening PR #45. |
I improved CI.