Add theme support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gjtorikian Sorry for the delay but I didn't have time earlier 😬. Works perfectly 🙂 It was the only thing I was missing, thanks! In the documentation you comment on this: |
|
Ah yeah, I guess that is a bit misleading, as there's not really an easy way to pull it off. Sorry for the mislead, I removed that line from the doc. I think you have to manually keep the values in sync, or, just save the JSON hash in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #31
@elalemanyo would you be able to clone this repo, checkout this branch, and see if this fixes the theming problem for you?